Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace our custom map implementation with walkers crate #12

Merged
merged 2 commits into from
Feb 18, 2024

Conversation

KoffeinFlummi
Copy link
Contributor

@KoffeinFlummi KoffeinFlummi commented Nov 25, 2023

Replaces our hacked-together map implementation with one based on the walkers crate.

MG7auAQ

Pros:

  • actually correct map rendering
  • less code for us to maintain
  • nice position labels
  • another tile provider beside mapbox, useful e.g. if no mapbox token is configured

Cons:

  • still requires some upstream changes

Upstream PRs/changes:

@podusowski
Copy link

Drop a word if you need some changes to be published on the cargo.io.

Cool project btw! :)

@KoffeinFlummi
Copy link
Contributor Author

Thanks, will do! Depending on time availability, I might get around to another PR or two soonish.

@KoffeinFlummi KoffeinFlummi marked this pull request as ready for review February 18, 2024 18:18
@KoffeinFlummi KoffeinFlummi merged commit b5a90dc into main Feb 18, 2024
2 checks passed
@KoffeinFlummi KoffeinFlummi deleted the walkers branch February 18, 2024 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants