Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add September 2024 Performance Points & Star Rating Updates news post #12159

Merged
merged 64 commits into from
Oct 28, 2024

Conversation

tsunyoku
Copy link
Member

@tsunyoku tsunyoku commented Sep 17, 2024

  • apply updated banner design

@tsunyoku tsunyoku requested a review from a team as a code owner September 17, 2024 11:34

## Release Schedule

<!-- todo -->
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've left this empty as I'm unsure what it will look like this time around. Likely requires input from @peppy.

Copy link
Contributor

@0x84f 0x84f left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just some cleaning up i havent given this a full read yet

@Walavouchey Walavouchey self-requested a review September 17, 2024 16:06
Copy link
Member

@peppy peppy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a brief initial review to get things rolling.


As a reminder of the various core values in the difficulty calculation algorithm:

- **Aim**: how difficult it is to consistently hit notes back-to-back (affected by approach rate, jumps, Hidden, Hard Rock and more)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these mentioned anywhere more permanently on the wiki? It feels like we want these definitions to be very front-and-foremost as not even I have an amazing concept of them.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They are mentioned on https://osu.ppy.sh/wiki/en/Performance_points#calculation, however looking at it I notice it's slightly outdated (for example, Flashlight is no longer part of Aim calculation)


### Combo scaling removal

A [change](https://github.com/ppy/osu/pull/16280) submitted by [moonpoint](https://osu.ppy.sh/users/9558549) with improvements made by [KermitNuggies](https://osu.ppy.sh/users/33452559) has been created in order to remove the combo scaling factor of a score on *both* aim and speed.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
A [change](https://github.com/ppy/osu/pull/16280) submitted by [moonpoint](https://osu.ppy.sh/users/9558549) with improvements made by [KermitNuggies](https://osu.ppy.sh/users/33452559) has been created in order to remove the combo scaling factor of a score on *both* aim and speed.
The most monumental [change](https://github.com/ppy/osu/pull/16280) proposed by [moonpoint](https://osu.ppy.sh/users/9558549) with improvements made by [KermitNuggies](https://osu.ppy.sh/users/33452559) – removes the "combo scaling factor" applied to the aim and speed portions of a score's PP.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The writing style of this whole post needs some serious review so I'll probably stop short here and leave it to @Walavouchey or someone else then revisit after things look better.


The miss penalty scaling is now based on the amount of difficult strains instead of object count. As the penalty is based upon the amount of difficult strains, this means longer maps with a lot of "filler" sections will be punished harder than longer beatmaps which are consistently difficult even if both beatmaps have similar object counts.

There were concerns raised about consistency being less important with these changes, however this isn't an issue. Using combo as a metric doesn't make much sense as the performance calculator does not know what sections of a beatmap that a score got misses on - as a result, we model any misses as being on the most difficult part.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First sentence reads really bad, stops halfway through, weird.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tried to improve it by connecting the two, but the sentence might be too long now. Open to suggestions on rewording because I can't really think of much.

@Walavouchey Walavouchey changed the title add September 2024 Performance Points & Star Rating Updates post Add September 2024 Performance Points & Star Rating Updates news post Sep 18, 2024
Comment on lines 69 to 71
In addition, the distance bonus scaling has been changed to decrease the reward for lower-spacing flow aim. Finally, a new multiplier was added to the final result of the distance bonus to decrease it overall.

![](/wiki/shared/news/2024-09-17-performance-points-star-rating-updates/distance-bonus.png)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wouldn't it be way better to illustrate the multiplicative-to-additive change in graph form than the change to the distance multiplier? isn't it way more of an impactful change?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it could be good to show the multiplicative-to-additive change, but I'm not really sure how you would illustrate it. The multiplicative-to-additive change doesn't change how the core bonuses work and just giving a graph that shows "this speed bonus and this distance bonus now results in x speed value instead of y speed value" doesn't seem particularly parse-able as a player - it'd just feel like random numbers on a graph whereas the distance bonus graph has a clearer understanding as it's using circle distance. Maybe I'm missing a good idea of how to display that change though - I'm open to it. Either way, I think the distance multiplier change is important to show regardless because it gives a good understanding at where lower spacing starts to get affected.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in that case i'd leave the graph out completely. showing that the "low ar distance bonus" is halved (appearance-wise, because the y axis starts at 0.25 or smth) gives no better intuition than the text description since the changes aren't in terms of actual pp values

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hm, I was thinking with the circle distance being the x-axis that it would give a good understanding of how the distance bonus scales even if that doesn't necessarily translate to pp directly - is it not intuitive to look at the graph and think "flow aim that is smaller than x circles distance is going to give a smaller bonus than before"? it just seems like a visualization of the explanation to me. the issue with the additive change was that you don't get this same intuition imo

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the graph shows two minimally adjusted curves that do need explanation, but what it's depicting is just a small part in the equation that i think is explained well enough in the revised text i suggested. it depicts a change in the code really, not what its effects are (i certainly didn't have a clue what the graph was about before reading the code)

will people think it's a small adjustment because of the small visual difference between the curves? will people think the pp for low spacing is halved since the y axis misleadingly starts at 0.25? will people understand how much and in what cases this "multiplier" affects things anyway? will people understand that the graph only depicts the second, smaller change in the first place? the circle distance thing on the x axis might be understandable to a larger proportion of readers, but the rest isn't

"lower-spacing fast flow aim is nerfed" is just about what needs to be conveyed for the distanceBonus change, and in general the combined effect is a sizeable nerf to flow aim for speed players - pishi's video explains this well, doesn't it?

a good way to show the effects of the pr in question might be to mention which maps get the largest change in pp and by how much (we have spreadsheets for this don't we). something like "most of the affected >1k pp plays lose about 40 to 70 pp from this change". maybe graphing this spreadsheet would be a better idea

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in the past we've given some examples of SR/PP changes on some maps that were effected by changes, I'll do the same here and remove the distance bonus graph


A recent [change](https://github.com/ppy/osu/pull/20558) by [vun](https://osu.ppy.sh/users/6932501) addresses these issues within the stamina system. When the new stamina system for osu!taiko was introduced in 2022, it assumed that players used two fingers per colour, leading to some impressive plays by players like [Ney](https://osu.ppy.sh/users/5991961) on [Alive](https://osu.ppy.sh/scores/1873110816) and others on [StrangeProgram](https://osu.ppy.sh/beatmapsets/5774#taiko/28065), which became notorious for yielding some speedy high PP scores.

The new system, while simple in its implementation, introduces variable finger counts for stamina. Mono-colour patterns that last more than 300ms without a colour change are now considered to have four fingers available. This adjustment significantly nerfs certain maps and converts. Additionally, convert-specific nerfs have been removed from difficulty calculations to ensure that converts are weighted fairly against mode-specific maps. The changes to finger count availability also ensure that more *niche* skill sets are fairly represented.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what "niche" skill sets? is it just the aforementioned tl-tapping method?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not ltca but i think the intention was to include other playstyles which may use 3 or 4 fingers per color in the phrasing, nothing specific

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could we then reword to something along the lines of The changes to finger count availability also ensure that play styles using varying amounts of fingers per colour are fairly represented?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i say go for it

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah that sounds fine to me. essentially yes its skillsets that utilise more than the set 2 finger count

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@peppy peppy self-requested a review October 24, 2024 11:04
@peppy peppy merged commit 961bff2 into ppy:master Oct 28, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.