Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add September 2024
Performance Points & Star Rating Updates
news post #12159Add September 2024
Performance Points & Star Rating Updates
news post #12159Changes from 7 commits
5f6e860
ce306a2
303432b
c449bc9
0dc2983
4ee5fc8
9cd6955
e869082
e53eb1e
430fbdd
d992ad0
ee02431
7f3bbcd
e051026
4fff511
918f31a
98c36dc
887d933
678c539
28457af
929f86b
701b1c0
9d41b93
b0a44fb
77ed274
8dd938b
e84f260
8a5bd7f
5a0705a
48419d2
d150fc2
53ef80f
35f30db
7d130fe
1e724fd
89b59b6
eca1941
909508a
c6671f4
f33cc27
6b2ab29
6a4e229
3db3d72
ef0e229
4905643
b8f91b2
d43b134
1afbdfb
bf00561
407b95a
b31f064
d97f8e5
4c2ed61
57bec6d
28e2f6d
2a311db
8446862
64d38e9
5201185
347b15b
b89de31
9dee8df
27d4b9f
b32f7a1
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've left this empty as I'm unsure what it will look like this time around. Likely requires input from @peppy.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are these mentioned anywhere more permanently on the wiki? It feels like we want these definitions to be very front-and-foremost as not even I have an amazing concept of them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They are mentioned on https://osu.ppy.sh/wiki/en/Performance_points#calculation, however looking at it I notice it's slightly outdated (for example, Flashlight is no longer part of Aim calculation)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The writing style of this whole post needs some serious review so I'll probably stop short here and leave it to @Walavouchey or someone else then revisit after things look better.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First sentence reads really bad, stops halfway through, weird.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've tried to improve it by connecting the two, but the sentence might be too long now. Open to suggestions on rewording because I can't really think of much.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what "niche" skill sets? is it just the aforementioned tl-tapping method?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Lawtrohux
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not ltca but i think the intention was to include other playstyles which may use 3 or 4 fingers per color in the phrasing, nothing specific
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could we then reword to something along the lines of
The changes to finger count availability also ensure that play styles using varying amounts of fingers per colour are fairly represented
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i say go for it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah that sounds fine to me. essentially yes its skillsets that utilise more than the set 2 finger count
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
8446862