Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend partial_sum_product() to cases tractable for Gaussians #584

Merged
merged 11 commits into from
Mar 2, 2022
Merged

Extend partial_sum_product() to cases tractable for Gaussians #584

merged 11 commits into from
Mar 2, 2022

Conversation

fritzo
Copy link
Member

@fritzo fritzo commented Feb 24, 2022 •
edited
Loading

Addresses #559
Blocked by #583
pair coded with @eb8680

Tested

  • added tests of intractable cases
  • added tests for unreduced sum variables in plates
  • added tests for batching, i.e. unreduced plate variables

@fritzo fritzo added Blocked Blocked by other issues awaiting review labels Feb 24, 2022
@fritzo fritzo requested a review from eb8680 February 24, 2022 00:08
@fritzo fritzo added WIP and removed Blocked Blocked by other issues awaiting review labels Feb 24, 2022
@fritzo fritzo added awaiting review and removed WIP labels Mar 1, 2022
eb8680
eb8680 approved these changes Mar 2, 2022
View reviewed changes
Copy link
Member

@eb8680 eb8680 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is OK to merge, since it's backwards compatible and raises conservative errors. Figuring out what should happen to uneliminated variables or plates can be left to future PRs.

@eb8680 eb8680 merged commit ecbe439 into master Mar 2, 2022
@eb8680 eb8680 deleted the tractable-for-gaussians branch March 2, 2022 19:58
@fritzo fritzo mentioned this pull request Mar 22, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eb8680 eb8680 eb8680 approved these changes

Assignees
No one assigned
Labels
awaiting review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fritzo @eb8680