Merge pull request #395 from qld-gov-au/QOLOE-441-aria-labelledby-for…

…-navigation-menu QOLOE-441 Removing redundant aria-labelledby from navigation bar
qld-gov-au · Jul 31, 2024 · 50d256a · 50d256a
2 parents 37c0cbd + c24f931
commit 50d256a
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/src/components/bs5/header/header.hbs b/src/components/bs5/header/header.hbs
@@ -187,7 +187,7 @@
                                 {{/if}}
                             </a>
                             {{#if dropdown_enabled}}
-                            <ul class="dropdown-menu dark" aria-labelledby="dropdown{{id}}" role="list">
+                            <ul class="dropdown-menu dark" role="list">
                                 {{#isType dropdown_options.dropdown_type "list"}}
                                     {{#if dropdown_options.dropdown_config}}
                                         {{#each dropdown_options.dropdown_config.groups}}

diff --git a/src/components/bs5/navbar/navbar.hbs b/src/components/bs5/navbar/navbar.hbs
@@ -44,7 +44,7 @@
                         </svg>
                     </a>
                     {{#if navigation_items}}
-                    <ul id="dropdown-menu" class="dropdown-menu" aria-labelledby="menuDropdown" role="menu"
+                    <ul id="dropdown-menu" class="dropdown-menu" role="menu"
                         data-bs-popper="none">
                         <div class="row dropdown-menu__inner">
                             {{#if dropdown_options}}
@@ -109,7 +109,7 @@
                         </button>
 
                         {{#if navigation_items}}
-                        <ul id="dropdown-menu" class="dropdown-menu" aria-labelledby="menuDropdown" role="menu"
+                        <ul id="dropdown-menu" class="dropdown-menu" role="menu"
                             data-bs-popper="none">
                             <div class="row dropdown-menu__inner">
                                 {{#if dropdown_options}}
@@ -187,7 +187,7 @@
                             </button>
 
                             {{#if dropdown_enabled}}
-                            <ul id="dropdown-menu-{{id}}" class="dropdown-menu" aria-labelledby="menuDropdown-{{id}}"
+                            <ul id="dropdown-menu-{{id}}" class="dropdown-menu"
                                 role="menu" data-bs-popper="none">
                                 <div class="row dropdown-menu__inner">
                                     {{#if dropdown_options.dropdown_config.groups}}