Panic if training output data is not one-dimensional #218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The GaussianProcess/SparsegGaussianProcess current fit API accepts a training output being a 2D array but the model implementations actually handle only one dimensional output (ie training output has to be a column vector).
Passing multiple output data leads to wrong predictors.
As a short-term measure, to enforce this constraint, this PR adds the check of the training output dimension and panic if it is not a column vector.
This comes from original Python SMT API (see SMTorg/smt#679) but actually should be revised in Rust. GP/SGP API should use an
Array1as the type for training outputs (instead of anArray2).