-
Notifications
You must be signed in to change notification settings - Fork 310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add strong type for limits #1981
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1981 +/- ##
==========================================
- Coverage 89.30% 89.25% -0.06%
==========================================
Files 130 130
Lines 14516 14527 +11
Branches 1258 1258
==========================================
+ Hits 12964 12966 +2
- Misses 1085 1091 +6
- Partials 467 470 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general, LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general looks very good to me.
@Wiktor-99 Thanks for the changes. I've proposed one more simple change to initialize the lower limit and upper limit with some default values. Let me know, what you think.
Sorry for not including this in my previous review
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, LGTM!
The PR fixes #1942