Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add strong type for limits #1981

Merged
merged 7 commits into from
Jan 11, 2025
Merged

Conversation

Wiktor-99
Copy link
Contributor

The PR fixes #1942

Copy link

codecov bot commented Jan 7, 2025

Codecov Report

Attention: Patch coverage is 96.29630% with 2 lines in your changes missing coverage. Please review.

Project coverage is 89.25%. Comparing base (d501f1b) to head (d4f60e0).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
joint_limits/src/joint_limits_helpers.cpp 93.33% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1981      +/-   ##
==========================================
- Coverage   89.30%   89.25%   -0.06%     
==========================================
  Files         130      130              
  Lines       14516    14527      +11     
  Branches     1258     1258              
==========================================
+ Hits        12964    12966       +2     
- Misses       1085     1091       +6     
- Partials      467      470       +3     
Flag Coverage Δ
unittests 89.25% <96.29%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...nt_limits/include/joint_limits/data_structures.hpp 100.00% <100.00%> (ø)
joint_limits/src/joint_range_limiter.cpp 84.37% <100.00%> (+0.24%) ⬆️
joint_limits/src/joint_saturation_limiter.cpp 85.63% <ø> (ø)
joint_limits/src/joint_soft_limiter.cpp 87.59% <100.00%> (+0.09%) ⬆️
joint_limits/src/joint_limits_helpers.cpp 91.42% <93.33%> (+0.12%) ⬆️

... and 4 files with indirect coverage changes

@christophfroehlich christophfroehlich changed the title Add strog type for limits Add strong type for limits Jan 7, 2025
Copy link
Member

@saikishor saikishor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general, LGTM

joint_limits/include/joint_limits/data_structures.hpp Outdated Show resolved Hide resolved
@Wiktor-99 Wiktor-99 requested a review from saikishor January 8, 2025 09:31
Copy link
Member

@saikishor saikishor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general looks very good to me.
@Wiktor-99 Thanks for the changes. I've proposed one more simple change to initialize the lower limit and upper limit with some default values. Let me know, what you think.

Sorry for not including this in my previous review

joint_limits/include/joint_limits/data_structures.hpp Outdated Show resolved Hide resolved
Copy link
Member

@saikishor saikishor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@christophfroehlich christophfroehlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM!

@saikishor saikishor merged commit f4c9dd0 into ros-controls:master Jan 11, 2025
23 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add strong typed return type of the helper methods
3 participants