Remove tf2 dependency #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmagyar
reviewed
Apr 5, 2020
|
Forgot to mention it, but since CI doesn't have any tests yet, I ran this through the tests from #13 as a sanity check. They all still pass. |
|
Hypot is C++11 by default... Sorry for the trouble, let's switch back to what we used to have, I wouldn't branch for this just yet, especially before the tests PR |
|
Oh right, forgot this is kinetic & melodic. No harm done, I learned something new today :) I'll revert back to |
matthew-reynolds
force-pushed
the
drop-tf2
branch
from
db0d371 to
c9e710e
Compare
|
Just rebased it |
bmagyar
approved these changes
Apr 5, 2020
|
Thanks for this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As @bmagyar mentioned in #10,
tf2is barely used, and we can easily remove the dependency on it to keep things slightly lighter.