Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add note about multi-robot launch file changes #631

Conversation

TannerGilbert
Copy link
Contributor

Documentation changes for ros-navigation/navigation2#4811.

Should I add an example of what was the problem with the original parsing namely that something like the following didn't work as expected:

IncludeLaunchDescription(
    PythonLaunchDescriptionSource(
        os.path.join(get_package_share_directory('nav2_bringup'), "launch", "cloned_multi_tb3_simulation_launch.py")
    ),
    launch_arguments={"robots": "robot1={x: 0.5, y: 0.5, yaw: 1.5707}"}.items(),
)

or is this not relevant for the documentation?

migration/Jazzy.rst Outdated Show resolved Hide resolved
Example to show how the cloned_multi_tb3_simulation_launch.py can be included from another launch file

Signed-off-by: Tanner, Gilbert <[email protected]>
Copy link
Member

@SteveMacenski SteveMacenski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just waiting on CI so I can check the output

@SteveMacenski SteveMacenski merged commit 0d907a3 into ros-navigation:master Jan 7, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants