Better log output when nodelet initialization fails #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flixr
reviewed
Jan 12, 2020
nodelet/src/loader.cpp
Outdated
| @@ -322,13 +322,13 @@ bool Loader::load(const std::string &name, const std::string& type, const ros::M | |||
|
|
|||
|
|
|||
| ROS_DEBUG("Done initing nodelet %s", name.c_str()); | |||
| } catch(...) { | |||
| } catch(std::runtime_error& e) { | |||
There was a problem hiding this comment.
what about other possible exceptions (although probably not likely)?
Maybe catch std::exception instead?
There was a problem hiding this comment.
You're right, but in this file, std::runtime_error is caught the same way in another location. If I changed it there, I'd have to change it at the other location for the sake of consistency.
The ultimately best way would be:
try {
//
} catch (const std::exception& e) {
// print error with e.what()
} catch (...} {
// print error without e.what() in case something not derived from std::exception was thrown
}
There was a problem hiding this comment.
Changed both to const std::exception& now, but without the default catch.
stertingen
force-pushed
the
fix_initialize_error_handling
branch
from
657c8e7 to
43d7b92
Compare
Also, catch const reference instead of non-const reference
stertingen
force-pushed
the
fix_initialize_error_handling
branch
from
43d7b92 to
b96daf2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This missing output of the initialization failure gave me a hard time debugging an rqt plugin.
Such errors should be visible without debug output turned on.
Furthermore, I noticed a slightly difference in code style (space before macro parenthesis, parenthesis around return value), which was also fixed.