Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README: expand description of packaging metadata #44124

Merged
merged 2 commits into from
Jan 11, 2025

Conversation

scpeters
Copy link
Contributor

@scpeters scpeters commented Jan 9, 2025

This is not a typical pull request; it's just updating the README with an expanded description of the two types of data contained in this repository in a way that I think is more readable. Thanks in advance for helping to correct any inaccuracies in my phrasing.

@scpeters scpeters marked this pull request as ready for review January 10, 2025 04:14
@jlblancoc
Copy link
Contributor

👍
I would prefer another wording instead of datasets, which for most of us in robotics has a different meaning than implied here... perhaps:

-The rosdistro repository stores two independent datasets used in ROS:
+This repository maintains:

@scpeters
Copy link
Contributor Author

👍 I would prefer another wording instead of datasets, which for most of us in robotics has a different meaning than implied here

how about "This repository maintains two independent sets of packaging metadata"?

@christophebedard
Copy link
Member

I also think that would be better.

@scpeters
Copy link
Contributor Author

👍 I would prefer another wording instead of datasets, which for most of us in robotics has a different meaning than implied here

how about "This repository maintains two independent sets of packaging metadata"?

applied in 5170aea

@scpeters scpeters changed the title README: expand description of data sets README: expand description of packaging metadata Jan 10, 2025
Copy link

@nuclearsandwich-ai nuclearsandwich-ai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@nuclearsandwich nuclearsandwich merged commit b793e89 into ros:master Jan 11, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants