Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dynamixel_hardware_interface and dynamixel_interfaces #44169

Merged
merged 6 commits into from
Jan 14, 2025

Conversation

robotpilot
Copy link
Contributor

@robotpilot robotpilot commented Jan 13, 2025

Please Add This Package to be indexed in the rosdistro.

humble

The source is here:

https://github.com/ROBOTIS-GIT/dynamixel_hardware_interface
https://github.com/ROBOTIS-GIT/dynamixel_interfaces

Checks

  • All packages have a declared license in the package.xml
  • This repository has a LICENSE file
  • This package is expected to build on the submitted rosdistro

Issue

@github-actions github-actions bot added the humble Issue/PR is for the ROS 2 Humble distribution label Jan 13, 2025
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for sending a pull request to ROS distro!

This is an automated tool that helps check your pull request for correctness.
This tool checks a number of attributes associated with your ROS package and generates a report that helps our reviewers merge your pull request in a timely fashion. Here are a few things to consider when sending adding or updating a package to ROS Distro.
ROS Distro includes a very helpful CONTRIBUTING.md file that we recommend reading if it is your first time submitting a package.
Please also read the ROS Distro review guidelines which summarizes this release process.

ROS Distro Considerations

Package Considerations

Having your package included in a ROS Distro is a badge of quality, and we recommend that package developers strive to create packages of the highest quality. We recommend package developers review the following resources before submitting their package.

Need Help?

Please post your questions to Robotics Stack Exchange or refer to the #infra-help channel on our Discord server.


For changes related to yamllint:

  • ✅ All new lines of YAML pass linter checks

@robotpilot
Copy link
Contributor Author

I get an error as shown below, but it appears to be just a temporary network issue. Running the github action again seems to fix it.

fatal: unable to access 'https://github.com/ROBOTIS-GIT/dynamixel_hardware_interface.git/': The requested URL returned error: 500
fatal: unable to access 'https://github.com/ROBOTIS-GIT/dynamixel_hardware_interface.git/': The requested URL returned error: 502
remote: Internal Server Error
fatal: unable to access 'https://github.com/ROBOTIS-GIT/dynamixel_interfaces.git/': The requested URL returned error: 500
fatal: unable to access 'https://github.com/ROBOTIS-GIT/dynamixel_interfaces.git/': The requested URL returned error: 502

@christophebedard
Copy link
Member

Instead of opening a new PR with the same content, could you keep the existing one? This way the relevant conversation is directly in the PR.

If your PR is lingering, you can just comment on it again.

@robotpilot
Copy link
Contributor Author

Instead of opening a new PR with the same content, could you keep the existing one? This way the relevant conversation is directly in the PR.

If your PR is lingering, you can just comment on it again.

Hi, @christophebedard
We apologize for the inconvenience. Due to a branch issue with the previous PR, it is not possible to reopen it as shown in the attached photo. Please proceed to this PR.
Screenshot from 2025-01-14 10-15-51

@christophebedard
Copy link
Member

christophebedard commented Jan 14, 2025

Just to summarize:

  1. A package was released by someone else in Foxy under the name dynamixel_hardware_interface
  2. The package proposed by this PR for Humble has the same name (dynamixel_hardware_interface) but is a different implementation/not the same code
  3. The author/maintainer of the original package does not intend to release their package in newer distros (after Foxy) and they are fine with ROBOTIS releasing their own (official) package with the same name

We discussed this in today's ROS PMC meeting (2025-01-14) and we're good to go. Thank you for your patience.

@christophebedard christophebedard merged commit c517008 into ros:master Jan 14, 2025
5 checks passed
civerachb-cpr pushed a commit to civerachb-cpr/rosdistro that referenced this pull request Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
humble Issue/PR is for the ROS 2 Humble distribution
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants