Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build only selected packages to enable security. #325

Open
wants to merge 2 commits into
base: rolling
Choose a base branch
from

Conversation

fujitatomoya
Copy link
Contributor

build only selected packages to enable security to save time.

@fujitatomoya
Copy link
Contributor Author

related to ros2/ros2_documentation#4890

@fujitatomoya
Copy link
Contributor Author

@clalancette can you take a look?

@fujitatomoya fujitatomoya self-assigned this Dec 4, 2024
Copy link

codecov bot commented Dec 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.94%. Comparing base (5968e6b) to head (840766f).

Additional details and impacted files
@@           Coverage Diff            @@
##           rolling     #325   +/-   ##
========================================
  Coverage    88.94%   88.94%           
========================================
  Files           24       24           
  Lines          615      615           
  Branches        64       64           
========================================
  Hits           547      547           
  Misses          50       50           
  Partials        18       18           
Flag Coverage Δ
unittests 88.94% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you change the rest of the "ROS2" -> "ROS 2" in the docs as well?

Also, just double-checking; have you checked that this compile-line is enough to enable security?

SROS2_Windows.md Outdated Show resolved Hide resolved
Signed-off-by: Tomoya.Fujita <[email protected]>
@fujitatomoya
Copy link
Contributor Author

@clalancette

Also, just double-checking; have you checked that this compile-line is enough to enable security?

Yes i have confirmed that is no problem to enable security.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants