-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build only selected packages to enable security. #325
base: rolling
Are you sure you want to change the base?
Conversation
Signed-off-by: Tomoya Fujita <[email protected]>
related to ros2/ros2_documentation#4890 |
@clalancette can you take a look? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## rolling #325 +/- ##
========================================
Coverage 88.94% 88.94%
========================================
Files 24 24
Lines 615 615
Branches 64 64
========================================
Hits 547 547
Misses 50 50
Partials 18 18
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you change the rest of the "ROS2" -> "ROS 2" in the docs as well?
Also, just double-checking; have you checked that this compile-line is enough to enable security?
Signed-off-by: Tomoya.Fujita <[email protected]>
Yes i have confirmed that is no problem to enable security. |
build only selected packages to enable security to save time.