27 import mop directly #44
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… of "univalent carboacylation"
…OP:0000410, MOP:0000411
MOP:0000543, MOP:0000550, MOP:0000555, MOP:0000556, MOP:0000561, MOP:0000562, MOP:0000563, MOP:0000564, MOP:0000565
MOP:0000572, MOP:0000573, MOP:0000574, MOP:0000575, MOP:0000576, MOP:0000577, MOP:0000578, MOP:0000579, MOP:0000580, MOP:0000581
MOP:0000584, MOP:0000585, MOP:0000586, MOP:0000587 and MOP:0000588
MOP:0000619, MOP:0000627, MOP:0000628, MOP:0000642, MOP:0000650, MOP:0000656, MOP:0000671, MOP:0000705, MOP:0000713, MOP:0000714, MOP:0000715, MOP:0000716, MOP:0000717, MOP:0000718, MOP:0000719, MOP:0000720
MOP:0000721, MOP:0000730-0000740, MOP:0000790-0000795, MOP:0000802, MOP:0000825, MOP:0000826, MOP:0001369, MOP:0001458, MOP:0001550, MOP:0002364, MOP:0002369, MOP:0002411, MOP:0002479, MOP:0002524, MOP:0003339, MOP:0003479, MOP:0003524, MOP:0006369
…correct its superclass subsumption in MOP
This reverts commit b0bf4e2.
…owl and correct its superclass subsumption in MOP" This reverts commit d9a6663.
…l subclass axiom to mop-edit.owl
…4 from rxno-edit.owl
MOP:0000566 MOP:0000567 MOP:0000568 MOP:0000569 MOP:0000570
copied subclassOf axiom: 'has participant beginning to exist' some 'primary alcohol'
copied subclassOf axioms: 'has participant beginning to exist' some 'secondary alcohol', 'has participant ceasing to exist' some ketone
can be deleted as is in RXNO, as sublcassOf axiom is already provided in MOP for the superclass
subsume children according to RXNO:0000344 before its obsoletion and add axiomatization as proposed in rsc-ontologies#27 (comment)
MOP:0000591 is the correct ID for 'carboxylation' but was wrongly declared with MOP:0000713 in RXNO --> affects subclass RXNO:0000182; copied "has_participant some 'carboxy group'" axiom to MOP:0000591 in MOP and deleted this class in RXNO, also made comments to reflect this change; parent (acylation) was already changed to be a subclass of "organylation" in 202e215
"carbonyl oxidation to alkyne" only declared in RXNO with an ID that was already taken in MOP --> copy all to MOP but mint new ID for it
"[3+2] cycloaddition" had wrong ID in RXNO, was taken by MOP already, thus needed a new ID to be minted in MOP
…t in MOP and thus drop equivalentTo axiom in MOP and change textual definition to the one previously provided in RXNO
add "realizes some enolisability" subclassOf axiom in MOP and change genus in textual definition according to equivalentTo axiom.
…rxno into 27_importMOP_directly
update issue branch
carboacylation (MOP_0000028) had both as parents acylation (MOP_0000479) and 'formation of covalent bond with carbon centre' (MOP_0000800); but as MOP_0000800 is already the parent of MOP_0000479, this assertion is not needed
…_0000458 (organylation)
…cleavage" and alkene oxidative cleavage reason:'has occurrent part' some 'breaking of covalent bond' is too inspecific as it doesn't restrict it to the reactive centre, which would be actually needed in this case. thus keeping both parents see also: rsc-ontologies#27 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #27