Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add pl rv unit tests #293

Merged
merged 1 commit into from
Oct 13, 2021
Merged

Add pl rv unit tests #293

merged 1 commit into from
Oct 13, 2021

Conversation

sblunt
Copy link
Owner

@sblunt sblunt commented Oct 5, 2021

Partially addresses issue #275

@sblunt sblunt changed the base branch from main to plotting-api October 5, 2021 22:45
@coveralls
Copy link

Pull Request Test Coverage Report for Build 1659

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.04%) to 88.373%
Totals Coverage Status
Change from base Build 1634: 0.04%
Covered Lines: 2189
Relevant Lines: 2477
💛 - Coveralls

@sblunt sblunt mentioned this pull request Oct 8, 2021
Closed
semaphoreP
semaphoreP approved these changes Oct 12, 2021
View reviewed changes
Copy link
Collaborator

@semaphoreP semaphoreP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@sblunt sblunt merged commit 4757161 into plotting-api Oct 13, 2021
@sblunt sblunt deleted the add-pl-rv-unit-tests branch October 13, 2021 20:53
@sblunt sblunt mentioned this pull request Oct 13, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@semaphoreP semaphoreP semaphoreP approved these changes

@hgallamore hgallamore Awaiting requested review from hgallamore

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sblunt @coveralls @semaphoreP