-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
decompose affine into simpler transformations #327
Conversation
Please check the docstring of the |
I added some tests, but at each run the function is also doing some additional lightweight checks before returning, so if there are bugs we catch them. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #327 +/- ##
==========================================
- Coverage 91.42% 90.69% -0.73%
==========================================
Files 36 36
Lines 4849 4740 -109
==========================================
- Hits 4433 4299 -134
- Misses 416 441 +25
|
Please also have a look at the much simpler |
@timtreis I made some changes, I added the parameter |
Other PR have more priorities for code review. Gonna merge since the PR is thoroughly tested and since I am going to test it manually again when refactoring the transformations using this code. CC @kevinyamauchi @giovp |
Helper function for @timtreis as asked in #314.