Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added api for renaming coordinate systems #392

Merged
merged 6 commits into from
Nov 2, 2023
Merged

Conversation

LucaMarconato
Copy link
Member

TLDR;

Use case

Simple but convenient API, I wrote so that I can rename the coordinate systems of Visium samples read with visium() before concatenating into a unique object, with one coordinate system per sample.

@LucaMarconato
Copy link
Member Author

The test fails for unrelated reasons, gonna fix them.

Copy link

codecov bot commented Nov 2, 2023

Codecov Report

Merging #392 (ec0338f) into main (b25ec12) will increase coverage by 0.15%.
Report is 2 commits behind head on main.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #392      +/-   ##
==========================================
+ Coverage   91.42%   91.57%   +0.15%     
==========================================
  Files          36       36              
  Lines        4849     4936      +87     
==========================================
+ Hits         4433     4520      +87     
  Misses        416      416              
Files Coverage Δ
src/spatialdata/_core/spatialdata.py 93.89% <100.00%> (+0.29%) ⬆️
src/spatialdata/datasets.py 100.00% <100.00%> (ø)
src/spatialdata/transformations/transformations.py 92.36% <100.00%> (+0.87%) ⬆️

@LucaMarconato LucaMarconato merged commit 0446eff into main Nov 2, 2023
7 checks passed
@LucaMarconato LucaMarconato deleted the feature/rename_cs branch November 2, 2023 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant