Use a guard and not .error? method for sensu_ctl #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I don't remember the reason for trying to use .error? to check the output of the shell exec. What matters though is that the configure is run once when needed and not every time once it's already configured. This change switches to using a guard and a method to compare the configured backend url. The shortcoming of this approach is that as resource is currently written it supports a username and password property, however we do not have an implementation that can safely handle reconfiguring these values so they will only work the first time the resource is used.
webframp
changed the title
webframp
added
the
Status: Do Not Merge
|
@majormoses just a start here to experiment with an alternate approach |
|
This one still needs work and isn’t ready to be included for #80 yet |
majormoses
reviewed
Jan 6, 2020
| execute 'configure sensuctl' do | ||
| command sensuctl_configure_cmd | ||
| sensitive true unless new_resource.debug | ||
| not_if { config['api-url'] == new_resource.backend_url } |
There was a problem hiding this comment.
this still would not allow you to reconfigure the credentials using the same URL, I am wondering if we should perhaps have a configure and reconfigure actions with their own distinct logic (yes I realize this is very anti pattern) as I can't seem to find a good middle ground that gives us what we want for both scenarios.
webframp
changed the title
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't remember the reason for trying to use
.error?to check theoutput of the shell exec. What matters though is that the configure is
run once when needed and not every time once it's already configured.
This change switches to using a guard and a method to compare the
configured backend url.
The shortcoming of this approach is that as the resource is currently
written it supports a username and password property, however we do not
have an implementation that can safely handle reconfiguring these
values so they will only work the first time the resource is used.
Fixes #63
Pull Request Checklist
Is this in reference to an existing issue?
General
Update Changelog following the conventions laid out here
Update README with any necessary configuration snippets
Cookstyle (rubocop) passes
Foodcritic passes
Rspec (unit tests) passes
Inspec (integration tests) passes
New Features
Added a Testing Artifact as either an automated test or a manual artifact on the PR.
Adedd documentation for it to the
README.mdPurpose
Known Compatibility Issues