Downgrade VorbisPizza back to 1.3.0 #5607
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Somewhere between 1.3.0 and 1.4.0 (I tested all versions) exists a bug that for some reason messes with the audio on some devices. A proper fix would require us trying to make contact with the developer of VorbisPizza, find the buggy commit and waiting them to update their repo. This repo has been inactive for 8 months. I doubt we can get support unless we fork it and find the bug ourselves. Closes & fixes space-wizards#5605
VasilisThePikachu
requested review from
PJB3005 and
DrSmugleaf
as code owners
|
omw to engine maint 😎 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Somewhere between 1.3.0 and 1.4.0 (I tested all versions) exists a bug that for some reason messes with the audio on some devices.
A proper fix would require us trying to make contact with the developer of VorbisPizza, find the buggy commit and waiting them to update their package. This repo has been inactive for 8 months. I doubt we can get support unless we fork it and find the bug ourselves. This is the path of least resistance to at least get the effected players back.
Closes & fixes #5605 and space-wizards/space-station-14#34418
Reproduced?: Yes, myself: Macbook Air M1 2020.
A total of 34~ players have expressed this bug exists. On different operating systems and hardware. Primerly low spec hardware.
I request an engine release, as some forks and devs are effected currently.