Remove all references to central store

[jotaylor]

Some scripts were wholesale removed (and instead stored in the private ullyses_dp repo). Other references to central store were turned into run-time arguments.

[jotaylor]

@wfischer-stsci can you confirm the change I made to lcogt_uphot.pro were done correctly? Sincerely, a python user.

[tapastro]

There are also some data csv files containing refs - are those no longer used once the changes in this PR are merged?

[wfischer-stsci]

OK, I'm grasping this a bit better now. The problem is that the function get_counts needs to know about datadir. As written, the user supplies datadir when they call the main program lcogt_uphot but that information does not get passed along to get_counts.

We could make that happen.

But can we just use the lcogt_uphot.pro that's in the lcogt branch? That has been tested to give the same results as previous versions, but the code is better organized.

[wfischer-stsci]

Tyler has a good point -- a file like V-BP-TAU_cal_fields.csv has a lot of references to central store in it.

Each line has an MJD, an image of a monitoring star obtained on that MJD, and the specific external calibration field that's supposed to go with it. One could remove every recurrence of /astro/ullyses/lcogt_data/ from that file and have the code supply that part of the filename instead.

[jotaylor]

@tapastro were there any other requested changes for this branch, or can it be merged? I believe Will removed the central store references in the lcogt branch which was just merged into main :)

[tapastro]

This PR is against the dr5b branch - I haven't kept up with the state of this release, so I'd have to take a look. Are these changes being applied to main as well, or are they already there or not applicable?

[jotaylor]

This PR is against the dr5b branch - I haven't kept up with the state of this release, so I'd have to take a look. Are these changes being applied to main as well, or are they already there or not applicable?

These change have not been applied to main, but maybe they should be (minus the changes that are now obsolete). Removing references to central store is a good thing to do no matter what. I can chat with you sometime about the open branches in this PR, and I'll just leave this for now.