spidercoordinator: fix auto fetch podCIDRType

[cyclinder]

---

name: Pull request
about: Tell us about your contribution
labels: ["pr/release/none-required"]

---

Thanks for contributing !

Before submitting a pull request, make sure you read about our Contribution notice here: https://spidernet-io.github.io/spiderpool/latest/develop/contributing/

What this PR does / why we need it:

• improve the code side
• fix unable to auto fetch the podCIDRType

Which issue(s) this PR fixes:

#2433

Special notes for your reviewer:

make sure your commit is signed off

[weizhoublue]

这个协调器的 handle 代码中，最后会做如下 逻辑

	if reflect.DeepEqual(coordCopy.Status, coord.Status) {
		return nil
	}

因此，此处，应该只需要 设置 copy.Status.， 无需额外调用一次 cc.Client.Status() ， 以减少一次 api 交互

[cyclinder]

没注意到最后有更新status

[codecov]

Codecov Report

Merging #2434 (e019315) into main (8894fdd) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #2434   +/-   ##
=======================================
  Coverage   80.97%   80.97%           
=======================================
  Files          49       49           
  Lines        5251     5251           
=======================================
  Hits         4252     4252           
  Misses        842      842           
  Partials      157      157           

Flag	Coverage Δ
unittests	80.97% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

[weizhoublue]

这么改 改出 bug 了 ， 原来的 代码 中， 最终的 return err 需要 反应 这个 patch 的成功，现在 patch 成功与否，不能 影响 这个回调的返回码。会导致 协调器 后续 重新入队 失败

原来的 代码 挺好的

[cyclinder]

go 的 defer 机制，如果在函数的返回中声明了变量以及类型，真正返回时会将 defer 中赋值完了再返回，举个例子：

package main

import "fmt"

func main() {

	fmt.Println(t1())

}

func t1() (a int) {
	a = 1
	defer func() {
		a = 2
	}()

	a = 3
	return 
}
root@cyclinder:/home/cyclinder/github/spiderpool/cmd/test# go run main.go 
2

[cyclinder]

这块可以优化下，放在一个地方处理status, 等我参考参考metallb

[weizhoublue]

我理解你的场景：你需要的 是 做一次 清除 cidr，但是又要 返回 error
所以，原来 的逻辑 不满足你了

[cyclinder]

还是不要defer，增加代码维护门槛

[weizhoublue]

我觉得在 usage/install/overlay 下的 md ，setup spiderpool 后，得 加入一个步骤，check 这个 cr， 看 cidr 等 符合预期 ，这个是 overlay 搭配场景下的一个重要 验证

[weizhoublue]

E2E 里拉起 calico 和 cilium 的 cidr ，故意和 cluster pod cidr 的不同，用于测试

[cyclinder]

It's OK to merge this.

[weizhoublue]

(1) add CALICO_CLUSTER_POD_SUBNET_V4 to test/Makefile.defs
(2) CILIUM_CLUSTER_POD_SUBNET_V4 has been defined and different from CLUSTER_POD_SUBNET_V4, why the issue did not happen in cilium cluster before ?

[cyclinder]

why the issue did not happen in cilium cluster before ?

Currently, E2E does not test pods the connectivity of the underlay NIC and the overlay NIC, so even if the overlay CIDRType is wrong, e2e also can pass.

[weizhoublue]

@ty-dc are there any E2E planned for this ?

[ty-dc]

@ty-dc are there any E2E planned for this ?

Use kdcotor for connectivity testing, but it does not test the connectivity of the pod's underlying NIC and overlay NIC. To do this, add an issue and resolve it as soon as possible.