Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

coodirnator: optimize the detectiong timeout for ip conflict and gateway detection #4512

utils: improve unittest coverage

1268120
Select commit
Loading
Failed to load commit list.
Merged

coodirnator: optimize the detectiong timeout for ip conflict and gateway detection #4512

utils: improve unittest coverage
1268120
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jan 3, 2025 in 0s

80.58% (target 60.00%)

View this Pull Request on Codecov

80.58% (target 60.00%)

Details

Codecov Report

Attention: Patch coverage is 83.58209% with 11 lines in your changes missing coverage. Please review.

Project coverage is 80.58%. Comparing base (16fd442) to head (1268120).

Files with missing lines Patch % Lines
pkg/utils/utils.go 83.58% 7 Missing and 4 partials ⚠️
Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                @@
##           release-v0.8    #4512       +/-   ##
=================================================
+ Coverage          1.40%   80.58%   +79.17%     
=================================================
  Files                54       50        -4     
  Lines              6332     5552      -780     
=================================================
+ Hits                 89     4474     +4385     
+ Misses             6233      906     -5327     
- Partials             10      172      +162     
Files with missing lines Coverage Δ
pkg/utils/utils.go 68.86% <83.58%> (ø)

... and 54 files with indirect coverage changes