-
Notifications
You must be signed in to change notification settings - Fork 663
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FC] Prepares integrity on first sync call #9818
[FC] Prepares integrity on first sync call #9818
Conversation
Diffuse output:
APK
|
706894d
to
04b27ef
Compare
69c825d
to
1f9ede2
Compare
1f9ede2
to
f49fde3
Compare
5c4c9af
to
cc8fb23
Compare
1840272
to
ef32d6f
Compare
cc8fb23
to
fa975d8
Compare
ef32d6f
to
8b718ff
Compare
fa975d8
to
81df1b9
Compare
9be7b86
to
67af8e1
Compare
81df1b9
to
f9c9ea6
Compare
67af8e1
to
eaa23cd
Compare
f9c9ea6
to
c2335d0
Compare
eaa23cd
to
b376dfb
Compare
c2335d0
to
18a1ac0
Compare
b376dfb
to
196fb04
Compare
@@ -111,6 +114,7 @@ internal class FinancialConnectionsSheetViewModel @Inject constructor( | |||
private fun fetchManifest() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: Should we rename this now that multiple things are happening in it?
@@ -120,6 +124,20 @@ internal class FinancialConnectionsSheetViewModel @Inject constructor( | |||
} | |||
} | |||
|
|||
private suspend fun prepareStandardRequestManager(): Boolean { | |||
val result = runCatching { integrityRequestManager.prepare() } | |||
result.exceptionOrNull()?.let { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: You can use result.onFailure { … }
.
18a1ac0
to
6405e3c
Compare
196fb04
to
0692e55
Compare
0692e55
to
e3b89e3
Compare
6405e3c
to
3147184
Compare
The base branch was changed.
e3b89e3
to
7ed2677
Compare
7ed2677
to
4bfb6b4
Compare
Merge activity
|
Summary
Call
Integrity#prepare
on Activity A (FinancialConnectionsSheetActivity
) and reuse the same Integrity instance in Activity B (FinancialConnectionsNativeActivity
) when generating tokens.Motivation
https://docs.google.com/document/d/1joKz5UZHLVazmecfMHbq6gB6n4wj5u8To6AtqYgq_tc/edit?tab=t.0#heading=h.cz1xkpga7giy
Testing