-
Notifications
You must be signed in to change notification settings - Fork 663
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FC] Add app verification to signup
flows (Networking+ID)
#9830
[FC] Add app verification to signup
flows (Networking+ID)
#9830
Conversation
f9b77e8
to
f0e8694
Compare
Diffuse output:
APK
DEX
|
8881bad
to
fc381b6
Compare
signup
flows (Networking+ID)
83d5bb9
to
077d40d
Compare
fc381b6
to
6732c0b
Compare
077d40d
to
6e7869f
Compare
6732c0b
to
30ff0fa
Compare
6e7869f
to
121957d
Compare
30ff0fa
to
d440b8b
Compare
121957d
to
d2e2584
Compare
d440b8b
to
95103be
Compare
d2e2584
to
656119b
Compare
95103be
to
439af93
Compare
656119b
to
ee050b2
Compare
c466db6
to
8984961
Compare
ee050b2
to
69327fb
Compare
8984961
to
5a1f7e4
Compare
69327fb
to
d820ca2
Compare
5a1f7e4
to
738d2c0
Compare
d820ca2
to
e32dab7
Compare
738d2c0
to
4e61478
Compare
0acfafe
to
bdcf9f7
Compare
3574205
to
827243e
Compare
827243e
to
1951e79
Compare
bdcf9f7
to
96e9ba3
Compare
93f4ce1
to
9fd1a9f
Compare
// SaveAccountToLink endpoint Signs up when providing email + phone number | ||
// **and** saves accounts to link in the same request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
// SaveAccountToLink endpoint Signs up when providing email + phone number | |
// **and** saves accounts to link in the same request. | |
// SaveAccountToLink endpoint signs up when providing email + phone number | |
// **and** saves accounts to Link in the same request. |
@@ -111,6 +121,7 @@ internal interface FinancialConnectionsConsumerSessionRepository { | |||
} | |||
} | |||
|
|||
@Suppress("TooManyFunctions") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we capture this in our baseline file instead?
}.getOrThrow() | ||
} | ||
|
||
override suspend fun mobileSignUp( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we make both signUp
methods call some internal method, so that we can avoid the code duplication?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added performSignUp
!
) | ||
|
||
@Test | ||
fun `performSignup should navigate to next pane on success`() = runTest { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you also add a test for the non-verified case?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done! also added a test For the Networking Handler.
ac2c19d
to
2b2a4e4
Compare
2b2a4e4
to
ed914cb
Compare
Summary
Added mobile signup endpoint and shared
SignUpParams
.We'll be calling the new mobile signup endpoint on verified flows (
manifest.app_verification_enabled
).To better understand the changes see this tables of endpoint changes for Networking and IBP:
Motivation
Creating the foundation for implementing user sign up functionality in the Stripe Android SDK
Testing
Changelog
[Added] Created SignUpParams class structure for upcoming sign up implementation