Getting Dimensions tests to work #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edsu
force-pushed
the
dimensions-tests
branch
5 times, most recently
from
9364951 to
a1b02c5
Compare
|
rialto-orgs writes out the ORCIDs with the full URL, so I think you'd want to update the fixture data. |
lwrubel
approved these changes
Jun 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR gets the Dimensions tests to work using environment variables that docker-compose sets. You can also set them your
.envto run the tests locally. The Dimensions credentials were also added to Vault. These should hopefully work in Github Actions as well with the username/password stored as GitHub secrets.I reformatted the input data to match what I think it will look like when rialto-orgs writes it out (using orcid URLs instead of bare ORCIDs).
Closes #36