Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Getting Dimensions tests to work #39

Merged
merged 1 commit into from
Jun 20, 2024
Merged

Getting Dimensions tests to work #39

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,3 +30,6 @@ jobs:
- name: Run tests
run: pytest
env:
AIRFLOW_VAR_DIMENSIONS_API_USER: ${{ secrets.AIRFLOW_VAR_DIMENSIONS_API_USER }}
AIRFLOW_VAR_DIMENSIONS_API_PASS: ${{ secrets.AIRFLOW_VAR_DIMENSIONS_API_PASS }}
7 changes: 4 additions & 3 deletions rialto_airflow/harvest/dimensions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,8 @@
dotenv.load_dotenv()

dimcli.login(
os.environ.get("DIMENSIONS_API_USER"),
os.environ.get("DIMENSIONS_API_PASS"),
os.environ.get("AIRFLOW_VAR_DIMENSIONS_API_USER"),
os.environ.get("AIRFLOW_VAR_DIMENSIONS_API_PASS"),
"https://app.dimensions.ai",
)

Expand Down Expand Up @@ -65,7 +65,8 @@ def dimensions_doi_orcids_dict(org_data_file, pickle_file, limit=None):
orcids = df[df["orcidid"].notna()]["orcidid"]
orcid_dois = {}

for orcid in orcids[:limit]:
for orcid_url in orcids[:limit]:
orcid = orcid_url.replace("https://orcid.org/", "")
dois = list(dimensions_dois_from_orcid(orcid))
orcid_dois.update({orcid: dois})

Expand Down
11 changes: 11 additions & 0 deletions test/data/authors.csv
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
sunetid,orcidid
sunet1,https://orcid.org/0000-0001-8705-1000
sunet2,https://orcid.org/0000-0003-2150-5828
sunet3,https://orcid.org/0000-0003-2150-5828
sunet4,https://orcid.org/0000-0002-0770-2940
sunet5,https://orcid.org/0000-0002-5270-1197
sunet6,https://orcid.org/0000-0002-7636-9758
sunet7,https://orcid.org/0000-0003-4670-0347
sunet8,https://orcid.org/0000-0002-5969-1251
sunet9,https://orcid.org/0000-0002-0426-2134
sunet10,https://orcid.org/0000-0002-0455-2086
15 changes: 8 additions & 7 deletions test/harvest/test_dimensions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,24 +7,25 @@

dotenv.load_dotenv()

dimensions_user = os.environ.get("DIMENSIONS_API_USER")
dimensions_password = os.environ.get("DIMENSIONS_API_PASS")
dimensions_user = os.environ.get("AIRFLOW_VAR_DIMENSIONS_API_USER")
dimensions_password = os.environ.get("AIRFLOW_VAR_DIMENSIONS_API_PASS")

no_auth = not (dimensions_user and dimensions_password)


@pytest.mark.skipif(no_auth, reason="no dimensions key")
def test_dimensions_doi_orcids_dict(tmpdir):
pickle_file = tmpdir / "dimensions.pickle"
dimensions_doi_orcids_dict(
"data/rialto_app/authors_2024-03-18.csv", pickle_file, limit=5
)
dimensions_doi_orcids_dict("test/data/authors.csv", pickle_file, limit=5)
assert pickle_file.isfile()

with open(pickle_file, "rb") as handle:
doi_orcids_dict = pickle.load(handle)
doi_orcids = pickle.load(handle)

assert len(doi_orcids_dict.keys()) == len(set(doi_orcids_dict.keys()))
assert len(doi_orcids) > 0
assert doi_orcids["https://doi.org/10.1109/lra.2018.2890209"] == [
"0000-0002-0770-2940"
]


def test_invert_dict():
Expand Down
Loading