-
-
Notifications
You must be signed in to change notification settings - Fork 638
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add recipe for rekalogika/gotenberg-pdf-bundle #1552
Conversation
priyadi
commented
Oct 17, 2023
Q | A |
---|---|
License | MIT |
Packagist | https://packagist.org/packages/rekalogika/gotenberg-pdf-bundle |
Thanks for the PR 😍 How to test these changes in your application
Diff between recipe versionsIn order to help with the review stage, I'm in charge of computing the diff between the various versions of patched recipes. |
Head branch was pushed to by a user without write access
@@ -0,0 +1,2 @@ | |||
rekalogika_gotenberg_pdf: | |||
url: 'http://%env(GOTENBERG_HOST)%:%env(GOTENBERG_PORT)%' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might it be simpler to have a single GOTENBERG_URL
variable that is set to the full https://...
? With the two variables, it doesn't let me use HTTP easily.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's what I had in mind, however, as far as I can tell, _HOST and _PORT are necessary for docker integration.
But how about my latest commit?
Head branch was pushed to by a user without write access
Head branch was pushed to by a user without write access