Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add recipe for rekalogika/gotenberg-pdf-bundle #1552

Merged
merged 4 commits into from
Oct 18, 2023
Merged

Add recipe for rekalogika/gotenberg-pdf-bundle #1552

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a4df200
Add recipe for rekalogika/gotenberg-pdf-bundle
priyadi Oct 17, 2023
e841bd3
ends files with newlines
priyadi Oct 17, 2023
139bfff
use GOTENBERG_URL, but retain GOTENBERG_HOST and GOTENBERG_PORT
priyadi Oct 17, 2023
2ed3740
add env comment for clarity
priyadi Oct 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions rekalogika/gotenberg-pdf-bundle/1.0/config/packages/rekalogika_gotenberg_pdf.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
rekalogika_gotenberg_pdf:
url: 'http://%env(GOTENBERG_HOST)%:%env(GOTENBERG_PORT)%'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might it be simpler to have a single GOTENBERG_URL variable that is set to the full https://...? With the two variables, it doesn't let me use HTTP easily.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's what I had in mind, however, as far as I can tell, _HOST and _PORT are necessary for docker integration.

But how about my latest commit?

28 changes: 28 additions & 0 deletions rekalogika/gotenberg-pdf-bundle/1.0/manifest.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,28 @@
{
"bundles": {
"Rekalogika\\GotenbergPdfBundle\\RekalogikaGotenbergPdfBundle": ["all"]
},
"copy-from-recipe": {
"config/": "%CONFIG_DIR%/"
},
"env": {
"GOTENBERG_HOST": "localhost",
"GOTENBERG_PORT": "3000"
},
"docker-compose": {
"docker-compose.yml": {
"services": [
"gotenberg:",
" image: docker.io/gotenberg/gotenberg:7"
]
},
"docker-compose.override.yml": {
"services": [
"gotenberg:",
" ports:",
" - \"3000\""
]
}
}
}

Loading