-
-
Notifications
You must be signed in to change notification settings - Fork 671
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(core): consistent naming of UI models #4479
Conversation
|
Needed for FIDO2 tests: trezor/fido2-tests#6 |
instead of |
I guess this makes more sense. Also, maybe I am late to the party - but since you are renaming stuff, have you thought about different naming scheme? American car brands are OK, but maybe we could come up with something more Czech? Cities, fictional characters, etc. |
fictional car brands https://mafiagame.fandom.com/wiki/Vehicles_in_Mafia#Vehicles |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please also update the fido2-tests submodule
Yes, except we have lots of features
Hmm, I wouldn't mind something different but "mercury" and "lincoln" are a part of everyday vocabulary within the team at this point :D |
maybe |
f145d8a
to
dc10be4
Compare
@prusnak After internal discussion with the team, we rename the individual UI layout implementation after the car brands from czech game series Mafia 😆 The names were chosen from this page: https://mafiagame.fandom.com/wiki/Vehicle_Brands |
- UI layouts name changes: - model_tt -> layout_bolt - model_tr -> layout_samson - model_mercury -> layout_quicksilver - rust features `model_xyz` freed for different use, now it's `layout_xyz` - input_flow function names are based on UI layout and not internal model name (i.e. quicksilver instead of t3t1) - directory names and commentary changed accordingly [no changelog]
dc10be4
to
7a1305f
Compare
model_xyz
freed for different use, now it'slayout_xyz
model name (i.e. quicksilver instead of t3t1)
[no changelog]