Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core): rework 'too many PIN attempts' RSOD #4483

Merged
merged 2 commits into from
Jan 10, 2025
Merged

fix(core): rework 'too many PIN attempts' RSOD #4483

merged 2 commits into from
Jan 10, 2025
+12 −14

Conversation

romanz
Copy link
Contributor

@romanz romanz commented Jan 9, 2025

Fixes #3324.

@romanz romanz self-assigned this Jan 9, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 9, 2025 •
edited
Loading

core UI changes device test click test persistence test
T2T1 Model T test(screens) main(screens) test(screens) main(screens) test(screens) main(screens)
T3B1 Safe 3 test(screens) main(screens) test(screens) main(screens) test(screens) main(screens)
T3T1 Safe 5 test(screens) main(screens) test(screens) main(screens) test(screens) main(screens)
All main(screens)

@romanz
Copy link
Contributor Author

romanz commented Jan 9, 2025

Tested on an emulator:
PIN

@romanz romanz marked this pull request as ready for review January 9, 2025 21:03
@romanz romanz requested a review from prusnak as a code owner January 9, 2025 21:03
@Hannsek Hannsek requested a review from matejcik January 10, 2025 07:13
@romanz romanz requested a review from obrusvit January 10, 2025 07:30
@romanz romanz added core Trezor Core firmware. Runs on Trezor Model T and T2B1. T2B1 Trezor Safe 3 (F4) T3B1 Trezor Safe 3 (U5) labels Jan 10, 2025
@romanz
Copy link
Contributor Author

romanz commented Jan 10, 2025

Thanks!
Rebasing to resolve the conflict following UI models rename, and updating the commits' messages.

romanz and others added 2 commits January 10, 2025 12:16
@romanz
refactor(core): remove an unused member from ErrorScreen
d61c5fe 
Also, rename `ErrorScreen::place` argument to `_bounds`,
similarly to how it's done in `model_quicksilver` and `model_bolt`.
@bieleluk @romanz
fix(core): rework 'too many PIN attempts' RSOD
2ca369e 
Also, allow multi-line title in `model_samson` `ErrorScreen`.

Co-authored-by: Roman Zeyde <[email protected]>
@romanz romanz force-pushed the romanz/fix-pin-msg branch from 9f1f56c to 2ca369e Compare January 10, 2025 11:30
@romanz romanz merged commit 1ef62aa into main Jan 10, 2025
95 checks passed
@romanz romanz deleted the romanz/fix-pin-msg branch January 10, 2025 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matejcik matejcik matejcik approved these changes

@prusnak prusnak Awaiting requested review from prusnak prusnak is a code owner

@obrusvit obrusvit Awaiting requested review from obrusvit

Assignees

@romanz romanz

Labels
core Trezor Core firmware. Runs on Trezor Model T and T2B1. T2B1 Trezor Safe 3 (F4) T3B1 Trezor Safe 3 (U5)
Projects
Firmware
Status: 🤝 Needs QA
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix "Too many PIN inputs" screen
3 participants
@romanz @matejcik @bieleluk