fix(vector): add minReadySeconds to StatefulSet and Deployment specs #367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jszwedko
approved these changes
Feb 9, 2024
|
@alexanderldavis it looks like there are some CI failures here when you get some time. |
auto-merge was automatically disabled
February 15, 2024 17:42
Head branch was pushed to by a user without write access
|
@jszwedko I'm struggling to find a good way to pass the linter for older kube versions. |
|
@alexanderldavis I was expecting the failing CI checks to block the automerge but apparently they didn't 😓 I opened #371 to revert.
My assumption would be that we'd only want to template it out for v1.25+ then, but maybe I'm missing something 🤔 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The chart currently supports
minReadySecondsfor DaemonSet-based deployments of the Vector agent. This PR extends this value to also apply to StatefulSets and Deployment specs.