Skip to content

Commit

Permalink
Merge pull request #29 from xchem/m2ms-1301
Browse files Browse the repository at this point in the history
Attempt to fix CI tests
  • Loading branch information
alanbchristie authored Jun 19, 2024
2 parents ad3032a + bdaa416 commit a13655f
Show file tree
Hide file tree
Showing 4 changed files with 40 additions and 68 deletions.
36 changes: 0 additions & 36 deletions .github/workflows/mypy.yaml

This file was deleted.

63 changes: 38 additions & 25 deletions .github/workflows/test.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -19,53 +19,66 @@ on:
jobs:
static-analysis:
runs-on: ubuntu-latest
strategy:
matrix:
python-version:
- "3.10"
- "3.11"
steps:
- name: Checkout
uses: actions/checkout@v3
uses: actions/checkout@v4
- name: Set up Python
uses: actions/setup-python@v3
uses: actions/setup-python@v5
with:
python-version: '3.10'
python-version: ${{ matrix.python-version }}
- name: Pre-commit check
run: |
pip install --upgrade pip
pip install .[dev]
pre-commit run --all-files
command-help:
command-execution:
runs-on: ubuntu-latest
strategy:
matrix:
python-version:
- "3.10"
- "3.11"
needs:
- static-analysis
steps:
- name: Checkout
uses: actions/checkout@v3
uses: actions/checkout@v4
- name: Set up Python
uses: actions/setup-python@v3
uses: actions/setup-python@v5
with:
python-version: '3.10'
- name: Test command help
python-version: ${{ matrix.python-version }}
- name: Install
run: |
pip install --upgrade pip
pip install .
- name: Test command help
run: |
python -m xchemalign.copier -h
python -m xchemalign.collator -h
python -m xchemalign.aligner -h
test-data:
runs-on: ubuntu-latest
needs:
- command-help
steps:
- name: Checkout
uses: actions/checkout@v3
- name: Set up Python
uses: actions/setup-python@v3
with:
python-version: '3.10'
- name: Test test-data config
- name: Test config_1
run: |
pip install --upgrade pip
pip install .
mkdir -p test-data/outputs/upload_1
python -m xchemalign.collator -c test-data/config.yaml
python -m xchemalign.aligner -d test-data/outputs/upload_1 -x test-data/xtalforms.yaml
python -m xchemalign.collator -c test-data/config_1.yaml
python -m xchemalign.aligner -d test-data/outputs/upload_1
# config-2 breaks with: -
# ! "KeyError: 'Mpro-x0107_fake_P1'"
# - name: Test config_2
# run: |
# mkdir -p test-data/outputs/upload_2
# python -m xchemalign.collator -c test-data/config_2.yaml
# python -m xchemalign.aligner -d test-data/outputs/upload_2
# config_3 fails with: -
# ! ERROR: reference Mpro-IBM0045 is not in the set of crystals to be processed
# ! ERROR: reference 5rgs is not in the set of crystals to be processed
# - name: Test config_3
# run: |
# mkdir -p test-data/outputs/upload_3
# python -m xchemalign.collator -c test-data/config_3.yaml
# python -m xchemalign.aligner -d test-data/outputs/upload_3
6 changes: 0 additions & 6 deletions .pre-commit-config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -27,12 +27,6 @@ repos:
- id: black
args:
- --skip-string-normalization
# MyPy
#- repo: https://github.com/pre-commit/mirrors-mypy
# rev: v1.3.0
# hooks:
# - id: mypy
# files: ^xchemalign
# Pylint
- repo: https://github.com/pycqa/pylint
rev: v2.17.4
Expand Down
3 changes: 2 additions & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ classifiers = [
description = "Tools to generate data suitable for loading into Fragalysis"
dependencies = [
'rdkit == 2023.3.2',
'numpy == 1.26.4',
'pandas == 1.5.3',
'pyyaml == 6.0',
'gemmi == 0.6.0',
Expand All @@ -26,7 +27,7 @@ dependencies = [
dynamic = ["version"]
license.file = "LICENSE"
readme = "README.md"
requires-python = ">=3.10"
requires-python = ">=3.10,<3.12.0"

#[tool.setuptools.packages.find]
#where = ["src/xchemalign"]
Expand Down

0 comments on commit a13655f

Please sign in to comment.