Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make some getters public, add various new mutable/immutable APIs and improve docs a bit #14

Merged
merged 8 commits into from
Feb 23, 2024

Conversation

sdroege
Copy link
Collaborator

@sdroege sdroege commented Feb 22, 2024

No description provided.

@sdroege sdroege requested a review from ystreet February 22, 2024 10:58
src/packet.rs Show resolved Hide resolved
src/packet.rs Show resolved Hide resolved
src/packet.rs Show resolved Hide resolved
src/packet.rs Show resolved Hide resolved
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 36.36364% with 28 lines in your changes are missing coverage. Please review.

Project coverage is 76.33%. Comparing base (0c3c1a9) to head (2211523).

Files Patch % Lines
src/edit.rs 10.00% 18 Missing ⚠️
src/packet.rs 60.00% 6 Missing ⚠️
src/builder.rs 55.55% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #14      +/-   ##
==========================================
- Coverage   82.06%   76.33%   -5.73%     
==========================================
  Files           3        3              
  Lines         368      393      +25     
==========================================
- Hits          302      300       -2     
- Misses         66       93      +27     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ystreet ystreet merged commit b9d2695 into main Feb 23, 2024
8 checks passed
@ystreet ystreet deleted the writable-extension-data branch February 23, 2024 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants