Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make some getters public, add various new mutable/immutable APIs and improve docs a bit #14

Merged
merged 8 commits into from
Feb 23, 2024
Merged

Make some getters public, add various new mutable/immutable APIs and improve docs a bit #14

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
817a2f6
Make a few getters in `RtpPacket` public
sdroege Feb 22, 2024
8507c71
Add getter for the payload length of a packet
sdroege Feb 22, 2024
db4088d
Use `unwrap_or_default()` instead of `if-let` in a place
sdroege Feb 22, 2024
45e8f22
Add missing periods to documentation comments.
sdroege Feb 22, 2024
75264c1
Use `[offset..][..len]` in one place instead of `[offset..offset+len]`
sdroege Feb 22, 2024
dcb4860
Add setter for extension ID and mutable getters for extension/payload…
sdroege Feb 22, 2024
ec77fda
Clean up lifetimes of packet builder write machinery
sdroege Feb 22, 2024
2211523
Rename `marker()` to `marker_bit()` everywhere and expose getters for…
sdroege Feb 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions src/packet.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,7 +154,8 @@ impl<'a> RtpPacket<'a> {
}
}

fn extension_bit(&self) -> bool {
/// Returns whether the extension bit is set for this packet.
pub fn extension_bit(&self) -> bool {
ystreet marked this conversation as resolved.
Show resolved Hide resolved
(self.data[0] & 0b0001_0000) != 0
}

Expand Down Expand Up @@ -213,7 +214,8 @@ impl<'a> RtpPacket<'a> {
Self::MIN_RTP_PACKET_LEN + (self.n_csrcs() as usize) * 4
}

fn extension_len(&self) -> usize {
/// Returns the length of the extension data in this packet.
pub fn extension_len(&self) -> usize {
ystreet marked this conversation as resolved.
Show resolved Hide resolved
if self.extension_bit() {
let offset = self.extension_offset();
4 * ((self.data[offset + 2] as usize) << 8 | self.data[offset + 3] as usize)
Expand All @@ -235,7 +237,8 @@ impl<'a> RtpPacket<'a> {
}
}

fn payload_offset(&self) -> usize {
/// Returns the offset of the payload in this packet relative to the beginning of the packet.
pub fn payload_offset(&self) -> usize {
ystreet marked this conversation as resolved.
Show resolved Hide resolved
self.extension_offset()
+ if self.extension_bit() {
self.extension_len() + 4
Expand Down