Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert change to delta filter #677

Merged
merged 2 commits into from
Jan 17, 2025
Merged

Conversation

dstansby
Copy link
Contributor

@dstansby dstansby commented Jan 4, 2025

This reverts #584, as it has caused two issues so far, one of which is unresolved: #653 and #595.

There is a proposed fix at #657, but that is held up under review.

In order to un-break zarr-python, I think reverting here is the right thing to do (so we can do a 0.15 release with other stuff).

My intention is to add a test to #653 to this PR too, so keeping as draft. Opening so there's time for folks to see that I'm intending to do this; cc @jakirkham @ehgus

@dstansby dstansby added the needs changelog Needs a changelog entry writing label Jan 4, 2025
Copy link

codecov bot commented Jan 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.70%. Comparing base (f005306) to head (fea7eda).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #677      +/-   ##
==========================================
- Coverage   99.70%   99.70%   -0.01%     
==========================================
  Files          62       62              
  Lines        2753     2751       -2     
==========================================
- Hits         2745     2743       -2     
  Misses          8        8              
Files with missing lines Coverage Δ
numcodecs/delta.py 100.00% <100.00%> (ø)

@dstansby dstansby added this to the 0.15.0 milestone Jan 4, 2025
@ehgus
Copy link
Contributor

ehgus commented Jan 6, 2025

I hope PR #657 will be reviewed soon as it fixes issue #653, which was caused by unsafe casting. In addition, this PR includes improved tests, so it will be glad someone feedback #657. Thank you for the remind.

@dstansby dstansby marked this pull request as ready for review January 17, 2025 08:16
@dstansby dstansby merged commit d8d53bb into zarr-developers:main Jan 17, 2025
23 of 24 checks passed
@dstansby dstansby deleted the revert-delta branch January 17, 2025 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs changelog Needs a changelog entry writing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants