-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test out unbreak of R build #127
Conversation
@jdblischak at
-- I think I need a |
Derp, nope ... https://github.com/TileDB-Inc/tiledb-feedstock-for-cloud/pull/22 🤔 |
@jdblischak additionally I'm confused by the solver error
since in the
🤔 |
Also puzzled this is mac-only, not Linux ... :think |
At https://anaconda.org/conda-forge/tiledb/files I see for example
🤔 |
@jdblischak @ihnorton where does
come from? |
tiledb 2.21.2 comes from the "run exports" of the tiledb recipe. Since libtiledbsoma was built against tiledb 2.21.2, it requires tiledb >=2.21.2,<2.22. This is the same problem we had last week with the cloud Docker files (which were pinning tiledb 2.21.1). For the cloud Docker files, we just had to update the TileDB env var pin to 2.21.2. In this case we'll need to migrate the aws version, so hopefully the solver error will be fixed by conda-forge/tiledb-feedstock#271 |
I just merged conda-forge/tiledb-feedstock#271. The build to monitor is at conda-forge/tiledb-feedstock@95e102d |
@jdblischak OK thank you! Meanwhile TileDB-SOMA -- as a package outside of Conda -- depends on 2.21.1. I tried single-cell-data/TileDB-SOMA#2424 but I found that TileDB-Py https://github.com/TileDB-Inc/TileDB-Py/releases/tag/0.27.1 is getting 2.21.1 and there is as yet no TileDB-Py 0.27.2 using 2.21.2. I'm not sure what's going to happen next but I'll continue working on this. |
If that is so, we would need to update all the pins in
Have we confirmed that is a strict requirement? While tiledb-py 0.27.1 bundles tiledb 2.21.1 (eg in its wheels uploaded to PyPI), it's my understanding that 0.27.1 should be compatible with any tiledb 2.21.*. That is how the tiledb-py-feedstock operates, so if my assumption is untrue, we should also fix that recipe As further evidence, the only difference between tiledb-py 0.27.0 and 0.27.1 is the bundled version of tiledb, which increases my confidence in my assertion that the 0.27.1 release was purely a mechanism for deploying tiledb 2.21.1 via the PyPI wheels |
Correct |
@jdblischak your theoretical reasoning is 100% solid & I wish it were that way. However on single-cell-data/TileDB-SOMA#2424 (comment) I found that 2.21.1 was actually getting found (admittedly, outside of Conda). We need to thread today's needle with regard to:
and see if we can get green CI on this feedstock PR. It's not clear to me yet how this will all unfold. |
I don't think that should affect the conda builds. That upstream CI job installed tiledb-py from a PyPI wheel, which bundles its own copy of libtiledb. I agree this is a general problem with non-conda builds, and something I continuously struggle with in my various nightly builds (ie the nightly builds only make sense if all the clients are using the same underlying version of the nightly libtiledb). But with the various conda builds, they will all be linked to the conda-installed libtiledb
|
This seems to be superseded by #129 so I'll abandon this attempt. |
single-cell-data/TileDB-SOMA#2414 [sc-44854] |
Context:
arrow
viaSuggests:
only easing the build requirements single-cell-data/TileDB-SOMA#2415