-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Power Control rewritten to Libgpiod #115
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KmakD
requested changes
May 11, 2023
Co-authored-by: Dawid Kmak <[email protected]>
Co-authored-by: Dawid Kmak <[email protected]>
Co-authored-by: Dawid Kmak <[email protected]>
KmakD
requested changes
May 12, 2023
KmakD
requested changes
Jun 27, 2023
Co-authored-by: Dawid Kmak <[email protected]>
KmakD
approved these changes
Jun 27, 2023
Kotochleb
added
invalid
This doesn't seem right
wontfix
This will not be worked on
and removed
invalid
This doesn't seem right
labels
Jun 27, 2023
macstepien
suggested changes
Jul 3, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that python code wasn't formatted with black
Co-authored-by: Maciej Stępień <[email protected]>
macstepien
reviewed
Jul 3, 2023
bump |
macstepien
approved these changes
Jul 4, 2023
macstepien
approved these changes
Jul 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bump::patch
Remove RPi.GPIO and use Libgpiod for GPIO control.
Currently, the implementation assumes hard-coded pin numbers for older robots.