-
Notifications
You must be signed in to change notification settings - Fork 804
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[sram_ctrl,dv] Add cov exclusion for tlul_lc_gate #25731
Conversation
aadbfec
to
18a8125
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm really sorry but I'm not really convinced by this reasoning. I was trying to write up another version of the same thing and I think the coverage item might be attainable. I'm not convinced it's worth caring about, but...
My notes:
// The condition we are excluding here is when outstanding_txn is nonzero when passing through the
// StErrorOutstanding state.
//
// For this to happen, we'd need to have an incomplete TL transaction pending (where the A side had
// happened but not the D side) when the gate became enabled, caused by the lc_en_i becoming On.
//
// The FSM state comes out of reset as StError but the lc_en_i signal is On at reset in sram_ctrl,
// so the FSM will follow the states StError (cycle 0), StErrorOutstanding (cycle 1), StActive
// (cycle 2). It *is* theoretically possible for a transaction to be enqueued in cycle zero because
// the TL inputs are top-level ports.
7c8d6c2
to
9cab9aa
Compare
Thanks @rswarbrick! I assumed that issuing a transaction in the very first cycles is not possible. However, you are right - as we can control the input ports we certainly also can issue such a transaction (though not sure if this is possible with the current TL-UL DV environment). I've updated the description according to your suggestion. |
I'm really sorry, but the text I put was me being lazy and copy-pasting from my notes when I was trying to prove the correctness of the waiver :-) Would you mind expanding on them a little and explaining why we're not worried about waiving it? |
Excluding as we cannot reach the else condition in this module. Detailed description is available in the .el file. Signed-off-by: Pascal Nasahl <[email protected]> Co-authored-by: Rupert Swarbrick <[email protected]>
9cab9aa
to
935d52d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working through the reasoning so carefully. This looks great to me!
Excluding as we cannot reach the else condition in this module. Detailed description is available in the .el file.