-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated mappings for the Hercules Inpulse 300 #12503
Conversation
Welcome at Mixxx! |
The pre-commit check is failing. The best way to fix pre-commit issues is to install pre-commit locally on your system, as described here: https://github.com/mixxxdj/mixxx/wiki/Using-Git#set-up-automatic-code-checking Please note, that this will not fix the typo, that the codespell check reports - this one must be fixed manually. |
Alright, I've filled out the agreement, installed pre-commit, and fixed all the typos and style issues. Let me know if there's anything else I need to do. |
Target for this PR should be 2.4 not main. Please rebase. |
If you need help with Git, have a look here: https://github.com/mixxxdj/mixxx/wiki/Using-Git#targeting-another-base-branch |
I'm still figuring my way around git, but assuming I rebased it properly, it should be ready to merge now. I also took the opportunity to add a whole bunch of other stuff, but now the manual PR is no longer up to date. I will be busy in the coming weeks, but hopefully I can get the manual up to speed after that. In the meantime, it would be nice to have some feedback on this mapping (especially from @DJPhatso ;) |
Pretty busy right now, but I'll see what I can do. |
Some feedback of what I was able to try:
Work as expected.
Been a while since I used this functionality in Traktor, so I might not be the best to judge if the flow is correct, but all functions were assigned as described.
Glad you could make it work as intended :-)
I noticed some unexpected scratching on occasion (i.e. without actually touching the wheels), which did no occur when I switched back to the default mapping (even tried with another unit to rule out some hardware problems), so there might be some adjustments to be done on that side. Looking at the script, there are a few User Options I might try to modify next time.
No problems there |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you. I don't think I can make any more informed comments. I trust you to have the mapping tested thoroughly as I can't confirm whether its working myself. @ywwg merge?
@BoredGuy1 can you fix the lint issues identified by the CI? they look like they are small things |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
address lint issues
sorry just one more set of lint!
|
Don't worry - I already know my code style is messy :P Let me know if there's any more lint issues - I'll gladly patch them. |
ok now that it passes, can you squash down some of the commits, especially the broken ones? you can do this by doing |
Let me see if I can figure it out. |
Fixed minor error on comment Reverted beatmatch code slightly Tested code, fixed ESLint issues Fixed even more ESLint issues 3rd time's the charm
Never mind, I don't think I did it right. If you can squash down the commits on your end, that would be great. @ywwg |
Lets continue on #14051. Thank you so far @BoredGuy1. |
I made some improvements to Mixxx's included Inpulse 300 mapping. I tried to stay close to the manufacturer mappings listed in this manual.
Full list of changes:
Added ability to stop samplers (shift + button)
Added toneplay
Added slicer/slicer loop:
Added actual beatmatch guide functionality to the LEDs
Changed the way scratching works
Updated VU meter syntax
Replaced "hotcue_X_enabled" with "hotcue_X_status" in XML file to comply with newer version of Mixxx
Manual is being updated accordingly in another PR: PR#604.