Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated mappings for the Hercules Inpulse 300 #14051

Merged
merged 1 commit into from
Dec 30, 2024
Merged

Updated mappings for the Hercules Inpulse 300 #14051

merged 1 commit into from
Dec 30, 2024

Conversation

ywwg
Copy link
Member

@ywwg ywwg commented Dec 23, 2024

Squashed version of #12503


original description:

I made some improvements to Mixxx's included Inpulse 300 mapping. I tried to stay close to the manufacturer mappings listed in this manual.

Full list of changes:

  • Added ability to stop samplers (shift + button)

  • Added toneplay

    • Pressing a pad jumps to the most recently used hotcue and changes the pitch
    • Shift + toneplay changes the pitch without jumping
    • Pads 1-4 increase the pitch by +0 to +3 semitones
    • Pads 5-8 decrease the pitch by -4 to -1 semitones
    • LED reflects total adjustment to current key
  • Added slicer/slicer loop:

    • Press slicer button to activate a slicer section, press again to deactivate it
    • Slicer length is dependent on loop length
    • Exiting slicer mode or pressing LOOP OUT also deactivates the slicer section
    • Creating a slicer section overrides active loops, and creating a 4-beat loop overrides active slicer sections
    • Only works on constant BPM (also true in native software DJUCED)
    • Slicer section does not move backwards when scratching (also true in native software DJUCED)
  • Added actual beatmatch guide functionality to the LEDs

    • This replaces the LEDs' old end-of-track warning functionality. Hopefully no one missed it :P
  • Changed the way scratching works

    • Wheels have inertia rather than instantly stopping when released (this allows backspins and other tricks)
    • Removed scratchPad in XML (not sure what it was doing there)
  • Updated VU meter syntax

    • Replaced vu_meter with VuMeter to comply with new version of Mixxx
    • Replaced connectControl with makeConnection to allow multiple connections (and also to comply with newer versions)
  • Replaced "hotcue_X_enabled" with "hotcue_X_status" in XML file to comply with newer version of Mixxx

Manual is being updated accordingly in another PR: PR#604.

@ywwg ywwg marked this pull request as ready for review December 23, 2024 21:46
Copy link
Member

@Swiftb0y Swiftb0y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please rebase on 2.5

@Holzhaus
Copy link
Member

Windows build is failing due to executable signing issues.

@ywwg
Copy link
Member Author

ywwg commented Dec 30, 2024

@BoredGuy1 please test and confirm that this includes all of your fixes. Then I can merge

@BoredGuy1
Copy link
Contributor

LGTM

@ywwg ywwg merged commit 44037e1 into 2.5 Dec 30, 2024
21 of 23 checks passed
@Swiftb0y Swiftb0y deleted the inpulse branch December 30, 2024 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants