-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: [IOBP-964] Add zendesk payment subcategories #446
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #446 +/- ##
==========================================
- Coverage 63.85% 63.80% -0.06%
==========================================
Files 167 166 -1
Lines 5437 5404 -33
Branches 746 749 +3
==========================================
- Hits 3472 3448 -24
+ Misses 1964 1955 -9
Partials 1 1
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
🎉 All dependencies have been resolved ! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
> [!WARNING] > this PR depends on pagopa/io-services-metadata#892 > this PR depends on pagopa/io-dev-api-server#446 ## Short description This pull request includes the addition of a new API request type for fetching `Zendesk` payment configuration, updates to the Redux store and sagas to handle this new configuration, and modifications to the payment failure support modal to utilize the new configuration. ## List of changes proposed in this pull request - Added a new type `GetZendeskPaymentConfigT` and a corresponding API request `getZendeskPaymentConfig` to fetch the Zendesk payment configuration - `handleGetZendeskPaymentConfig` to manage the side effects of fetching the Zendesk payment configuration and integrated it into the `watchZendeskSupportSaga` - Updated the payment failure support modal to dispatch the `getZendeskPaymentConfig` action and utilize the fetched configuration to set custom fields for Zendesk tickets ## How to test Ensure that the outcomes are accurately mapped to the corresponding subcategory when opening a ticket --------- Co-authored-by: Alessandro <[email protected]>
Warning
this PR depends on pagopa/io-services-metadata#892
Short description
This pull request add new subcategories for payment issues in both JSON files and updating the router to handle these new subcategories.
List of changes proposed in this pull request
io-service-metadata
How to test
Apri una richiesta
Pagamenti PagoPa
Screen.Recording.2024-12-09.at.10.19.30.mov