Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [IOBP-964] Add zendesk payment subcategories #446

Merged
merged 5 commits into from
Dec 10, 2024

Conversation

LeleDallas
Copy link
Contributor

@LeleDallas LeleDallas commented Dec 9, 2024

Warning

this PR depends on pagopa/io-services-metadata#892

Short description

This pull request add new subcategories for payment issues in both JSON files and updating the router to handle these new subcategories.

List of changes proposed in this pull request

  • Added new subcategories for various payment-related issues as defined in io-service-metadata
  • Added detailed descriptions for the new payment-related subcategories

How to test

  • After login tap on the top right question marker
  • Tap on Apri una richiesta
  • Tap on Pagamenti PagoPa
  • Verify that subcategories are displayed
  • Tap on each of them and verify if is possible to send a message
Screen.Recording.2024-12-09.at.10.19.30.mov

Copy link

codecov bot commented Dec 9, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 63.80%. Comparing base (e92e063) to head (4abe967).
Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
src/routers/services_metadata.ts 50.00% 4 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #446      +/-   ##
==========================================
- Coverage   63.85%   63.80%   -0.06%     
==========================================
  Files         167      166       -1     
  Lines        5437     5404      -33     
  Branches      746      749       +3     
==========================================
- Hits         3472     3448      -24     
+ Misses       1964     1955       -9     
  Partials        1        1              
Files with missing lines Coverage Δ
src/routers/services_metadata.ts 59.70% <50.00%> (-1.24%) ⬇️

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c7d8c71...4abe967. Read the comment docs.

Copy link

dpulls bot commented Dec 10, 2024

🎉 All dependencies have been resolved !

Copy link
Contributor

@Hantex9 Hantex9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@LeleDallas LeleDallas merged commit ae6e225 into master Dec 10, 2024
8 checks passed
LeleDallas added a commit to pagopa/io-app that referenced this pull request Dec 11, 2024
> [!WARNING]
> this PR depends on
pagopa/io-services-metadata#892
> this PR depends on
pagopa/io-dev-api-server#446

## Short description
This pull request includes the addition of a new API request type for
fetching `Zendesk` payment configuration, updates to the Redux store and
sagas to handle this new configuration, and modifications to the payment
failure support modal to utilize the new configuration.

## List of changes proposed in this pull request
- Added a new type `GetZendeskPaymentConfigT` and a corresponding API
request `getZendeskPaymentConfig` to fetch the Zendesk payment
configuration
- `handleGetZendeskPaymentConfig` to manage the side effects of fetching
the Zendesk payment configuration and integrated it into the
`watchZendeskSupportSaga`
- Updated the payment failure support modal to dispatch the
`getZendeskPaymentConfig` action and utilize the fetched configuration
to set custom fields for Zendesk tickets

## How to test
Ensure that the outcomes are accurately mapped to the corresponding
subcategory when opening a ticket

---------

Co-authored-by: Alessandro <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants