Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ez][HUD] Remove rockset from benchmarks branch and commit picker component #6131

Merged
merged 3 commits into from
Jan 3, 2025
Merged

[ez][HUD] Remove rockset from benchmarks branch and commit picker component #6131

merged 3 commits into from
Jan 3, 2025

Conversation

clee2000
Copy link
Contributor

@clee2000 clee2000 commented Jan 3, 2025 •
edited
Loading

As in title, remove rockset from the benchmarks pages' branch and commit picker and switch to ClickHouse always

@clee2000
Update
30c51c0 
[ghstack-poisoned]
@clee2000
Update
7f423f8 
[ghstack-poisoned]
@clee2000
Copy link
Contributor Author

clee2000 commented Jan 3, 2025 •
edited
Loading

Stack from ghstack (oldest at bottom):

@vercel Vercel
Copy link

vercel bot commented Jan 3, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Updated (UTC)
torchci ⬜️ Ignored (Inspect) Visit Preview Jan 3, 2025 8:52pm

This was referenced Jan 3, 2025
Merged
Merged
Merged
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 3, 2025
@clee2000 clee2000 changed the title tc [ez][HUD] Remove rockset from benchmarks branch and commit picker component Jan 3, 2025
@clee2000 clee2000 requested a review from a team January 3, 2025 18:33
This was referenced Jan 3, 2025
Closed
Merged
Merged
Merged
Base automatically changed from gh/clee2000/5/head to main January 3, 2025 20:50
@clee2000
Update
6ccbf03 
[ghstack-poisoned]
clee2000 added a commit that referenced this pull request Jan 3, 2025
@clee2000
tc
0702402 
ghstack-source-id: ab6b1a0d243e04a0f3e338d6aa337558c2eaae78
ghstack-comment-id: 2569647750
Pull Request resolved: #6131
@clee2000 clee2000 merged commit 9d46cf2 into main Jan 3, 2025
6 checks passed
@clee2000 clee2000 deleted the gh/clee2000/6/head branch January 3, 2025 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@huydhn huydhn huydhn approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@clee2000 @huydhn @facebook-github-bot