Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ez][HUD] Remove rockset from various comments, remove enableClickhouse function #6133

Merged
merged 15 commits into from
Jan 3, 2025
Merged

[ez][HUD] Remove rockset from various comments, remove enableClickhouse function #6133

merged 15 commits into from
Jan 3, 2025

Conversation

clee2000
Copy link
Contributor

@clee2000 clee2000 commented Jan 3, 2025 •
edited
Loading

Mostly just mentions in comments
Also removes the unused enableClickhouse function

@clee2000
Update
30c51c0 
[ghstack-poisoned]
@clee2000
Update
7f423f8 
[ghstack-poisoned]
@clee2000
Update
1e63668 
[ghstack-poisoned]
@clee2000
Update
c37c312 
[ghstack-poisoned]
@clee2000
Copy link
Contributor Author

clee2000 commented Jan 3, 2025 •
edited
Loading

Stack from ghstack (oldest at bottom):

@clee2000 clee2000 mentioned this pull request Jan 3, 2025
Merged
@vercel Vercel
Copy link

vercel bot commented Jan 3, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Updated (UTC)
torchci ⬜️ Ignored (Inspect) Visit Preview Jan 3, 2025 8:59pm

This was referenced Jan 3, 2025
Merged
Merged
clee2000 added a commit that referenced this pull request Jan 3, 2025
@clee2000
tc
dc5179a 
ghstack-source-id: edfe74a7124b59ea4c8f27d940472d00adc2bff3
ghstack-comment-id: 2569647895
Pull Request resolved: #6133
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 3, 2025
@clee2000 clee2000 changed the title tc [ez][HUD] Remove rockset from benchmarks branch picker component Jan 3, 2025
@clee2000 clee2000 mentioned this pull request Jan 3, 2025
Closed
@clee2000 clee2000 changed the title [ez][HUD] Remove rockset from benchmarks branch picker component [ez][HUD] Remove rockset from various comments, remove enableClickhouse function Jan 3, 2025
@clee2000 clee2000 requested a review from a team January 3, 2025 18:35
This was referenced Jan 3, 2025
Merged
Merged
Merged
@clee2000
Update
83ccad5 
[ghstack-poisoned]
@clee2000
Update
15472a5 
[ghstack-poisoned]
@clee2000
Update
2c9f881 
[ghstack-poisoned]
@clee2000
Update
58f29d0 
[ghstack-poisoned]
This was referenced Jan 3, 2025
Closed
Closed
@clee2000
Update
bbc2769 
[ghstack-poisoned]
@clee2000
Update
82a2326 
[ghstack-poisoned]
@clee2000
Update
4097739 
[ghstack-poisoned]
@clee2000
Update
073b312 
[ghstack-poisoned]
@clee2000 clee2000 mentioned this pull request Jan 3, 2025
Closed
@clee2000 clee2000 mentioned this pull request Jan 3, 2025
Closed
@clee2000
Update
faf1f4a 
[ghstack-poisoned]
@clee2000
Update
1fff30c 
[ghstack-poisoned]
Base automatically changed from gh/clee2000/7/head to main January 3, 2025 20:59
@clee2000
Update
05606af 
[ghstack-poisoned]
@clee2000 clee2000 merged commit 6cc4ad0 into main Jan 3, 2025
6 checks passed
@clee2000 clee2000 deleted the gh/clee2000/8/head branch January 3, 2025 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@huydhn huydhn huydhn approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@clee2000 @huydhn @facebook-github-bot