-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
project-schema.json: add lobbyingMeetings,Meetings,PublicOfficial obj… #428
Conversation
…ects and minutes.lobbyingMeeting code
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggest addressing the remainder of #409 in this PR too.
Please check and update the mapping and example for the related CoST IDS elements in sustainability.yaml
I've added the rest of #409, I've held off on that as it meant creating the parent |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Happy for you to request a review from James once you've resolved my comments.
I also added a few commits to remove consultationMeetings.publicOfficial
from example.json
, to link the public consultation meetings element in the climate finance module to the public consultation meetings element in the social module, and to remove empty examples from sustainability.md
. I can respond to any comments from James on those changes.
Co-authored-by: Duncan Dewhurst <[email protected]>
@jpmckinney if you could prioritise this PR review above the other OC4IDS PR reviews that would be great, as it contains some changes to make it possible to link to individual CoST IDS elements in |
Co-authored-by: James McKinney <[email protected]>
Co-authored-by: James McKinney <[email protected]>
@jpmckinney all suggestions now applied, are you ok for this to be merged or do you need to check again? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some very small edits, then can be merged.
Co-authored-by: James McKinney <[email protected]>
Given that there are a few other PRs that depend on this one, I've committed the suggestions and will merge it, just to speed things along :-) |
…ects and minutes.lobbyingMeeting code
Related issues
closes #412
closes #409
Description
I used the
Address
object formeeting.location
rather thanLocation
as a meeting is going to happen at an address not a geometry or gazetteer entry.Merge checklist
If there are changes to
project-schema.json
orproject-package-schema.json
:docs/examples/example.json
docs/examples/blank.json
./manage.py pre-commit
to updatedocs/_static/i8n.csv
If you added a new definition to the schema, run
./manage.py pre-commit
.If you added a new codelist:
docs/reference/codelists.md